fix: reset confirm-order loading after request failures - #13
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
Author
|
Could someone review the loading-state reset when you have a moment? Both request-failure paths have regression tests that fail on the base branch; all six unit tests pass after the fix. I can adjust the handling if the dialog is expected to stay loading after an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an instance creation or restore request rejects, ConfirmOrder shows the error but leaves the confirm button loading indefinitely. Reset loading in both rejection handlers so the user can retry.
Added network-error tests for both endpoints. They fail on the current branch and pass with this change. All 6 unit tests pass on Node 18; ESLint reports no errors in the changed component (2 existing warnings).